-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade controller-runtime to v0.7.0 #221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
force-pushed
the
controller-runtime-update
branch
from
December 17, 2020 19:26
0b722a7
to
bc04c98
Compare
phillebaba
reviewed
Dec 18, 2020
stefanprodan
force-pushed
the
controller-runtime-update
branch
2 times, most recently
from
December 18, 2020 08:21
6e3ea57
to
5b81fb9
Compare
hiddeco
reviewed
Dec 18, 2020
stefanprodan
force-pushed
the
controller-runtime-update
branch
4 times, most recently
from
December 18, 2020 10:40
647561c
to
f291617
Compare
hiddeco
reviewed
Dec 18, 2020
stefanprodan
force-pushed
the
controller-runtime-update
branch
from
December 18, 2020 13:54
f291617
to
6c0dfc2
Compare
stefanprodan
force-pushed
the
controller-runtime-update
branch
from
December 21, 2020 08:09
3dbf15c
to
bbb4776
Compare
Signed-off-by: Stefan Prodan <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
force-pushed
the
controller-runtime-update
branch
from
January 4, 2021 09:51
bbb4776
to
5a0e5ab
Compare
hiddeco
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ci
CI related issues and pull requests
enhancement
New feature or request
hold
Issues and pull requests put on hold
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the controller-runtime dependency to
v0.7.0
, fix: #214.Changes:
context.Context
passed to theReconcile
method and downwards functions.BindFlags
fromruntime/logger
, ensuring the same contract across GitOps Toolkit controllers, and the--log-json
flag has been deprecated in favour of the--log-encoding=json
default.ChangePredicate
fromruntime
has changed to aReconcilateAtChangedPredicate
, and is now chained with theGenerationChangedPredicate
fromcontroller-runtime
usingpredicate.Or
.runtime.Object
have changed toclient.Object
, removing the requirement to e.g. callruntime.Object#Object
.client.MatchingField
function was deprecated, and has been replaced withclient.MatchingFields{}
.leader-election-role
was changed, as leader election now works via thecoordination/v1
API.SourceIndexKey
constant has been split out into{GitRepository,Bucket}IndexKey
constants.util.ObjectKey
was added to easily construct aclient.ObjectKey
/types.NamespacedName
from ametav1.Object
.Impersonation changes:
KustomizeImpersonation
.Ref: fluxcd/flux2#613